-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change analogRead calls to analogReadPin #9023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
added
enhancement
core
keyboard
breaking_change
Changes that need to wait for a version increment
labels
May 5, 2020
noroadsleft
reviewed
May 6, 2020
noroadsleft
approved these changes
May 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__attribute__ ((weak))
✔️
fauxpark
force-pushed
the
ble-analogreadpin
branch
from
May 15, 2020 23:24
800a94e
to
5153c95
Compare
drashna
approved these changes
May 19, 2020
fauxpark
force-pushed
the
ble-analogreadpin
branch
from
May 23, 2020 11:54
5153c95
to
431df6b
Compare
fauxpark
force-pushed
the
ble-analogreadpin
branch
from
May 31, 2020 03:03
431df6b
to
55a6ea7
Compare
fauxpark
force-pushed
the
ble-analogreadpin
branch
from
June 8, 2020 11:08
44a80e2
to
58284ef
Compare
fauxpark
force-pushed
the
ble-analogreadpin
branch
from
June 20, 2020 04:49
58284ef
to
dbeeead
Compare
noroadsleft
pushed a commit
that referenced
this pull request
Jul 10, 2020
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
noroadsleft
pushed a commit
that referenced
this pull request
Jul 18, 2020
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
noroadsleft
pushed a commit
that referenced
this pull request
Jul 26, 2020
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
noroadsleft
pushed a commit
that referenced
this pull request
Jul 31, 2020
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
noroadsleft
pushed a commit
that referenced
this pull request
Aug 11, 2020
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
noroadsleft
pushed a commit
that referenced
this pull request
Aug 27, 2020
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
noroadsleft
pushed a commit
that referenced
this pull request
Aug 29, 2020
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Sep 6, 2020
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Sep 30, 2020
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Change analogRead calls to analogReadPin * Add ChangeLog * Update docs, remove mention of `analogRead()` * Retarget changelog for next round
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking_change
Changes that need to wait for a version increment
core
documentation
enhancement
keyboard
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Might as well get this done now.
analogRead()
will be removed later.Types of Changes
Issues Fixed or Closed by This PR
Checklist